Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting code with gofmt #2255

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Formatting code with gofmt #2255

merged 1 commit into from
Oct 8, 2024

Conversation

huochexizhan
Copy link
Contributor

No description provided.

Signed-off-by: huochexizhan <huochexizhan@outlook.com>
Copy link

@lnliz lnliz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Should linting be added as part of the Github action checks?

@huochexizhan
Copy link
Contributor Author

lgtm

Should linting be added as part of the Github action checks?

lgtm

Should linting be added as part of the Github action checks?

If the final conclusion needs to be added, I'm happy to submit a new PR to do it.

Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Would be nice to add linting/formatting to this project. The dockerized tools approach we use in lnd should be easy to port over: https://github.com/lightningnetwork/lnd/tree/master/tools

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11030695951

Details

  • 23 of 47 (48.94%) changed or added relevant lines in 1 file are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 57.215%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcclient/infrastructure.go 23 47 48.94%
Files with Coverage Reduction New Missed Lines %
connmgr/connmanager.go 2 86.27%
peer/peer.go 9 73.49%
Totals Coverage Status
Change from base Build 10970025081: -0.02%
Covered Lines: 29850
Relevant Lines: 52172

💛 - Coveralls

@huochexizhan
Copy link
Contributor Author

LGTM, thanks!

Would be nice to add linting/formatting to this project. The dockerized tools approach we use in lnd should be easy to port over: https://github.com/lightningnetwork/lnd/tree/master/tools

Thank you very much! I see you have approved it. Should I try to modify it on this PR or create a new one?

@guggero
Copy link
Collaborator

guggero commented Oct 8, 2024

Should I try to modify it on this PR or create a new one?

I think a new PR would be better, going to merge this one now.

@guggero guggero merged commit e9b505d into btcsuite:master Oct 8, 2024
3 checks passed
@huochexizhan
Copy link
Contributor Author

Should I try to modify it on this PR or create a new one?

I think a new PR would be better, going to merge this one now.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants