Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestThrottle failed travis #355

Closed
jrick opened this issue Feb 2, 2016 · 1 comment
Closed

TestThrottle failed travis #355

jrick opened this issue Feb 2, 2016 · 1 comment

Comments

@jrick
Copy link
Member

jrick commented Feb 2, 2016

Saw this from Travis-CI on a PR:

=== RUN TestThrottle
--- FAIL: TestThrottle (0.05s)
rpcserver_test.go:54: status codes: want: map[200:1 429:1], got: map[200:2]

Must be an intermittent issue because this is the first time I've seen this fail since the RPC throttling was added.

@jrick
Copy link
Member Author

jrick commented Mar 16, 2016

Looked at the test case and I can see it's a race there and not a bug with the throttle function (when isn't waiting using time.Sleep a race?). In this case, the sleep finished before the second handler started, so both handlers ran and returned HTTP 200 status codes.

jrick added a commit to jrick/btcwallet that referenced this issue Mar 16, 2016
jrick added a commit to jrick/btcwallet that referenced this issue Oct 13, 2016
jrick added a commit to jrick/btcwallet that referenced this issue Oct 13, 2016
cjepson pushed a commit to cjepson/btcwallet that referenced this issue Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant