Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settxfee races #379

Closed
jrick opened this issue Feb 29, 2016 · 0 comments
Closed

settxfee races #379

jrick opened this issue Feb 29, 2016 · 0 comments

Comments

@jrick
Copy link
Member

jrick commented Feb 29, 2016

The legacy RPC server's settxfee RPC causes data races when modifying the wallet's relay fee. Synchronization is needed.
jrick added a commit to jrick/btcwallet that referenced this issue Mar 9, 2016
@jrick
Protect the relay fee field with a mutex.
8a35540 
This prevents races when setting a new relay fee through the legacy
RPC server (settxfee).

Fixes btcsuite#379.
@jrick jrick mentioned this issue Mar 9, 2016
Merged
jrick added a commit to jrick/btcwallet that referenced this issue Mar 9, 2016
@jrick
Protect the relay fee field with a mutex.
d09c2a8 
This prevents races when setting a new relay fee through the legacy
RPC server (settxfee).

Fixes btcsuite#379.
@jrick jrick closed this as completed in #384 Mar 9, 2016
jrick added a commit to jrick/btcwallet that referenced this issue Nov 10, 2016
@jrick
Fix a bug in the semver compatibility check.
a813171 
While here, improve the error returned by RPCClient.Connect to include
both the required and advertised API versions.  These versions are
independent of the program and/or project's release versions, but it
should still be useful in determining whether dcrd must be downgraded
or upgraded for compatibility with this wallet software.

Add a 30 second sleep after any connection or compatibility errors
(where compatibility errors are not just incorrect API versions, but
mismatched currency networks as well).  This prevents an immediate
reconnect to the server.

Fixes btcsuite#379.
jrick added a commit to jrick/btcwallet that referenced this issue Nov 10, 2016
@jrick
Fix a bug in the semver compatibility check.
58a8922 
While here, improve the error returned by RPCClient.Connect to include
both the required and advertised API versions.  These versions are
independent of the program and/or project's release versions, but it
should still be useful in determining whether dcrd must be downgraded
or upgraded for compatibility with this wallet software.

Add a 30 second sleep after any connection or compatibility errors
(where compatibility errors are not just incorrect API versions, but
mismatched currency networks as well).  This prevents an immediate
reconnect to the server.

Fixes btcsuite#379.
jrick added a commit to jrick/btcwallet that referenced this issue Nov 10, 2016
@jrick
Fix a bug in the semver compatibility check. (btcsuite#380)
dba252e 
While here, improve the error returned by RPCClient.Connect to include
both the required and advertised API versions.  These versions are
independent of the program and/or project's release versions, but it
should still be useful in determining whether dcrd must be downgraded
or upgraded for compatibility with this wallet software.

Add a 30 second sleep after any connection or compatibility errors
(where compatibility errors are not just incorrect API versions, but
mismatched currency networks as well).  This prevents an immediate
reconnect to the server.

Fixes btcsuite#379.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrick