walletdb: add sequence methods from bbolt to the main bucket interface #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfromknecht
commented
Jan 5, 2020
| @@ -68,7 +68,7 @@ func (tx *transaction) ReadWriteBucket(key []byte) walletdb.ReadWriteBucket { | |||
| } | |||
|
|
|||
| func (tx *transaction) CreateTopLevelBucket(key []byte) (walletdb.ReadWriteBucket, error) { | |||
| boltBucket, err := tx.boltTx.CreateBucket(key) | |||
| boltBucket, err := tx.boltTx.CreateBucketIfNotExists(key) | |||
There was a problem hiding this comment.
is this change relevant to the pr?
There was a problem hiding this comment.
Discussed offline that without this change, there isn't a way to conditionally obtain/create a top-level bucket.
cfromknecht
force-pushed
the
walletdb-sequence
branch
2 times, most recently
from
30f3682 to
9e103f5
Compare
…ment In this commit, we add the trio of sequence based methods that bbolt ships with to the main bucket interface. We do this in order to easily allow walletdb as is to be slotted into place where bbolt is currently used, without sacrificing any functionality.
In this commit, we update our `go list` command to account for the changes to the output of the command when modules are active. If modules are active, then any packages which are themselves a sub-module won't properly be listed.
In this commit, we add a new package-level function to emulate the existing Batch interface for bbolt. We do this via a new super-set interface which is then checked against in the main implementation of the Batch method.
cfromknecht
force-pushed
the
walletdb-sequence
branch
from
9e103f5 to
2c6a714
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add the trio of sequence based methods that
bboltships with to the main bucket interface. We do this in order to easily allow walletdb as is to be slotted into place where bbolt is currently used, without sacrificing any functionality.Along the way we fix some issues with sub-modules that resulted in packges not being tested against the latest set of sub-modules. We also resolve an issue with
goclean.shthat prevented any packages which were themselves sub-modules from being run.