move common code to superclass

bterlson · Nov 29, 2018 · 7f056fb · 7f056fb
1 parent 0cbc375
commit 7f056fb
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 52 deletions.
diff --git a/lib/Reporter.js b/lib/Reporter.js
@@ -3,9 +3,30 @@ const chalk = require('chalk');
 module.exports = class Reporter {
   constructor (options = {}) {
     this.options = options;
+    this.source = undefined;
+    this.results = [];
   }
-  start() {}
-  result(host, result) {}
+
+  start(source) {
+    this.source = source;
+
+    if (this.options.showSource) {
+      Reporter.printSource(source);
+    }
+  }
+
+  result(host, result) {
+    let resultCell = result.stdout.trim();
+    if (result.error) {
+      resultCell += '\n' + chalk.red(`${result.error.name}: ${result.error.message}`);
+    }
+    resultCell = resultCell.replace(/\r/g, '');
+
+    this.results.push([
+      host.name, resultCell
+    ]);
+  }
+
   end() {}
 
   get isUnanimous() {

diff --git a/lib/reporters/default.js b/lib/reporters/default.js
@@ -2,29 +2,6 @@ const Reporter = require('../Reporter.js');
 const chalk = require('chalk');
 
 module.exports = class DefaultReporter extends Reporter {
-  constructor(options) {
-    super(options);
-    this.source = undefined;
-    this.results = [];
-    this.resultsMap = {};
-  }
-  start(source) {
-    this.source = source;
-
-    if (this.options.showSource) {
-      Reporter.printSource(source);
-    }
-  }
-  result(host, result) {
-    let resultString = result.stdout.trim();
-    if (result.error) {
-      resultString += chalk.red(`${result.error.name}: ${result.error.message}`);
-    }
-
-    this.results.push([
-      host.name, resultString
-    ]);
-  }
   end() {
     if (this.options.unanimous && this.isUnanimous) {
       process.exit(0);

diff --git a/lib/reporters/table.js b/lib/reporters/table.js
@@ -3,33 +3,6 @@ const chalk = require('chalk');
 const Table = require('cli-table');
 
 module.exports = class TableReporter extends Reporter {
-  constructor(options) {
-    super(options);
-    this.source = undefined;
-    this.results = [];
-    this.resultsMap = {};
-  }
-
-  start(source) {
-    this.source = source;
-
-    if (this.options.showSource) {
-      Reporter.printSource(source);
-    }
-  }
-
-  result(host, result) {
-    let resultCell = result.stdout.trim();
-    if (result.error) {
-      resultCell += '\n' + chalk.red(`${result.error.name}: ${result.error.message}`);
-    }
-    resultCell = resultCell.replace(/\r/g, '');
-
-    this.results.push([
-      host.name, resultCell
-    ]);
-  }
-
   end() {
     if (this.options.unanimous && this.isUnanimous) {
       process.exit(0);