eshost --add: support inclusion of --tags (see details for examples) #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaldron
force-pushed
the
add-tags-with-host
branch
from
1d4a09d to
61d171b
Compare
rwaldron
commented
Aug 1, 2017
lib/host-manager.js
Outdated
| path = Path.join(process.cwd(), path); | ||
| } | ||
|
|
||
| config.hosts[name] = { type, path, args }; | ||
| if (tags) { | ||
| if (typeof tags === 'string') { |
There was a problem hiding this comment.
Meh. I suppose these could be combined into a single expression
dilijev
reviewed
Aug 1, 2017
lib/host-manager.js
Outdated
| config.hosts[name] = { type, path, args }; | ||
| if (tags) { | ||
| if (typeof tags === 'string') { | ||
| tags = [tags]; |
There was a problem hiding this comment.
Isn't this already taken care of with hostTags = argv.tags.split(','); (and then hostTags is passed in for the tags param to this function?
There was a problem hiding this comment.
Indeed it is. I will correct this.
- eshost --add ch ch `which ch` --tags latest - eshost --add ch ch `which ch` --tags latest,greatest Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
rwaldron
force-pushed
the
add-tags-with-host
branch
from
61d171b to
97c9cda
Compare
|
Assuming the "approval" is still valid, I'd like to include this in tested features, so I'm landing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which ch--tags latestwhich ch--tags latest,greatestTests will follow in another PR which contains all the tests that I've written
Signed-off-by: Rick Waldron waldron.rick@gmail.com