Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Update information about portal #147

Merged
merged 3 commits into from
Aug 12, 2024
Merged

README: Update information about portal #147

merged 3 commits into from
Aug 12, 2024

Conversation

rherilier
Copy link
Contributor

The section about portal seems to be a bit outdated.

@rherilier
Copy link
Contributor Author

The Known Limitations section had an outdated entry too...

Copy link
Owner

@btzy btzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good, but afaik the wlroots backend doesn't come with a file chooser.

Also, more for my understanding - do you know what the difference between the GTK and the Gnome backend is? The file chooser code in their repos look identical.

README.md Outdated

### What is a portal?

Unlike Windows and macOS, Linux does not have a file chooser baked into the operating system. Linux applications that want a file chooser usually link with a library that provides one (such as GTK, as in the Linux screenshot above). This is a mostly acceptable solution that many applications use, but may make the file chooser look foreign on non-GTK distros.

Flatpak was introduced in 2015, and with it came a standardized interface to open a file chooser. Applications using this interface did not need to come with a file chooser, and could use the one provided by Flatpak. This interface became known as the desktop portal, and its use expanded to non-Flatpak applications. Now, most major desktop Linux distros come with the desktop portal installed, with file choosers that fit the theme of the distro. Users can also install a different portal backend if desired. There are currently two known backends: GTK and KDE. (XFCE does not currently seem to have a portal backend.)
Flatpak was introduced in 2015, and with it came a standardized interface to open a file chooser. Applications using this interface did not need to come with a file chooser, and could use the one provided by Flatpak. This interface became known as the desktop portal, and its use expanded to non-Flatpak applications. Now, most major desktop Linux distros come with the desktop portal installed, with file choosers that fit the theme of the distro. Users can also install a different portal backend if desired. There are currently many backends: GTK, Gnome, KDE, or wlroots; see the [desktop portal page](https://flatpak.github.io/xdg-desktop-portal/) for a complete list.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think I was told that xdg-desktop-portal-wlr doesn't have a file chooser, and so wlroots users need to also install another portal backend to use a file chooser. Do you know if wlroots really supports it now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I was too hasty...

From my (slower) understanding (and just for the file chooser part):

  • xdg-desktop-portal-wlr still does not support it.
  • xdg-desktop-portal-gnome depends on xdg-desktop-portal-gtk to provide it (according to apt show xdg-desktop-portal-gnome).
  • xdg-desktop-portal-xapp too.
  • xdg-desktop-portal-gtk implements its own file chooser.
  • xdg-desktop-portal-kde too.
  • xdg-desktop-portal-lxqt too.

So, many desktop managers support it (my half-baked wording) but the backends providing the file chooser are only Gtk, KDE, and LXQt (the original wording).

If you are fine with it, I will simply reuse the original text and add LXQt as a third backend.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the elaboration! Yes, I think we can add LXQt as a third backend, and also adopt your other suggestion to say that Cinnamon, MATE and XFCE can rely on the Xapp backend.

@rherilier
Copy link
Contributor Author

I forget to tell that Cinnamon, MATE & Xfce can support portal with the Xapp backend (which depends on the GTK one). AFAICT, other desktop environment do not seems to support portal.

So:

(XFCE does not currently seem to have a portal backend.)

could be rewritten into:

(desktop environment like Cinnamon, MATE or XFCE can rely on the Xapp backend to support file chooser; other desktop environments do not currently seem to have a portal backend.)

Copy link
Owner

@btzy btzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@btzy btzy merged commit 2a7440a into btzy:master Aug 12, 2024
31 checks passed
@rherilier
Copy link
Contributor Author

Thanks for the last fixes and the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants