updates

bufbuild · Feb 7, 2024 · 89c0eec · 89c0eec
1 parent a207178
commit 89c0eec
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/private/pkg/protosource/option_extension_descriptor.go b/private/pkg/protosource/option_extension_descriptor.go
@@ -127,7 +127,7 @@ func isDescendantPath(descendant, ancestor []int32) bool {
 	return true
 }
 
-func (o *optionExtensionDescriptor) ForEachFieldDescriptor(fn func(protoreflect.FieldDescriptor, protoreflect.Value) bool) {
+func (o *optionExtensionDescriptor) ForEachPresentOption(fn func(protoreflect.FieldDescriptor, protoreflect.Value) bool) {
 	// Note: This does not bother to handle unrecognized fields.
 	// Should not be a problem since descriptors models in the buf CLI codebase should have them
 	// all correctly parsed and known.

diff --git a/private/pkg/protosource/protosource.go b/private/pkg/protosource/protosource.go
@@ -152,10 +152,12 @@ type OptionExtensionDescriptor interface {
 	// have a set value on this descriptor.
 	PresentExtensionNumbers() []int32
 
-	// ForEachFieldDescriptor iterates through all fields present in the options message invoking
-	// the callback for each one. If the callback returns false, it terminates the
-	// iteration and returns immediately.
-	ForEachFieldDescriptor(fn func(protoreflect.FieldDescriptor, protoreflect.Value) bool)
+	// ForEachPresentOption iterates through all options that have a set value on this
+	// descriptor, invoking fn for each present option.
+	//
+	// If fn returns false, the iteration is terminated and ForEachPresentOption
+	// immediately returns.
+	ForEachPresentOption(fn func(protoreflect.FieldDescriptor, protoreflect.Value) bool)
 }
 
 // Location defines source code info location information.