Remove duplicated code for scaffolding git repository #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saquibmian
commented
Nov 10, 2023
| t.Logf("run %q", strings.Join(append([]string{cmd}, args...), " ")) | ||
| _, err := io.Copy(os.Stderr, stderr) | ||
| require.NoError(t, err) | ||
| require.FailNow( |
There was a problem hiding this comment.
This improves the error message so that it's right in the test failures as opposed to stderr.
--- FAIL: TestCommitsToSyncWithNoPreviousSyncPoints (0.28s)
gittest.go:204:
Error Trace: /Users/saquib/dev/buf/private/pkg/git/gittest/gittest.go:204
/Users/saquib/dev/buf/private/pkg/git/gittest/repository.go:68
/Users/saquib/dev/buf/private/buf/bufsync/commits_to_sync_test.go:131
/Users/saquib/dev/buf/private/buf/bufsync/commits_to_sync_test.go:39
Error: git command failed: "git checkout bar": exit status 1
Test: TestCommitsToSyncWithNoPreviousSyncPoints
Messages: error: pathspec 'bar' did not match any file(s) known to git
unmultimedio
approved these changes
Nov 10, 2023
unmultimedio
approved these changes
Nov 10, 2023
saquibmian
deleted the
saquib/bsr-3029-change-scaffoldrepository-to-conditionally-create-empty
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.