Move protected branch determination to handler #2569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is preparation for protected branches being asserted server side.
| GetModuleReleaseBranch( | ||
| // IsProtectedBranch is invoked when syncing branches to know if a branch's history is protected | ||
| // and must not diverge since the last sync. If an error is returned, sync will abort. | ||
| IsProtectedBranch( |
There was a problem hiding this comment.
Nit: we could invoke just once per module identity and get protectedBranches []string
There was a problem hiding this comment.
We could, but the flow isn't like that right now. We cache anyway, so this is fine.
unmultimedio
approved these changes
Nov 11, 2023
…out-to-isprotectedbranch
saquibmian
deleted the
saquib/bsr-3027-move-protected-branch-logic-out-to-isprotectedbranch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparation for protected branches being asserted server side.