Update bufcas and slicesextended #2572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallsamantha
approved these changes
Nov 12, 2023
Alfus
approved these changes
Nov 12, 2023
emcfarlane
reviewed
Nov 13, 2023
| @@ -66,10 +67,16 @@ func (d DigestType) String() string { | |||
| // ParseDigestType parses a DigestType from its string representation. | |||
| // | |||
| // This reverses DigestType.String(). | |||
| // | |||
| // Returns an error of type *ParseError if thie string could not be parsed. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
ReduceandCountfunctions toslicesextended.ParseErrortobufcas. Anerrorof type*bufcas.ParseErroris returned frombufcas.Parse.*functions on unsuccessful parsing. This will allow us to understand the nature of anerrorreturned from the newModuleKey.Digest(), and handle situations such as Ignore b1/b3 buf.lock digests only #2111. Instead of blanking out the error from abuf.lockfile, we can instead return an error saying we did not understand theDigestType, and handle that accordingly in places where we don't support it.bufcaswith respect to conversion to/from repeated Protobuf types.