Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HandleReadModuleError #2585

Merged
merged 7 commits into from
Nov 15, 2023
Merged

Remove HandleReadModuleError #2585

merged 7 commits into from
Nov 15, 2023

Commits on Nov 13, 2023

  1. Remove HandleReadModuleError 

    The logic is instead inlined because it's a core decision that Syncer should make.
    @saquibmian
    saquibmian committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    b402d15 View commit details
    Browse the repository at this point in the history

  2. Handle nil module

    @saquibmian
    saquibmian committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    8e6a6f3 View commit details
    Browse the repository at this point in the history

  3. Kill unused LookbackDecisionCode

    @saquibmian
    saquibmian committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    a6d0bd0 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Merge branch 'main' into saquib/bsr-3037-remove-handlereadmoduleerror

    @saquibmian
    saquibmian committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    772d8dd View commit details
    Browse the repository at this point in the history

  2. Missing case

    @saquibmian
    saquibmian committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    b5682b1 View commit details
    Browse the repository at this point in the history

  3. One more spot

    @saquibmian
    saquibmian committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    ecc7ad8 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. pr comments

    @saquibmian
    saquibmian committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    c6ef6dd View commit details
    Browse the repository at this point in the history