Make logger and repository service client optional in api module reader #2594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliversun9
requested review from
pkwarren,
unmultimedio,
emcfarlane and
bufdev
pkwarren
reviewed
Nov 15, 2023
pkwarren
approved these changes
Nov 15, 2023
bufdev
approved these changes
Nov 15, 2023
oliversun9
deleted the
osun/make-logger-and-repo-service-client-optional-in-api-module-reader
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bufmoduleapi.ModuleReaderis also used in the elsewhere, where this reader does not need to print warning when a module is deprecated (the CLI is the only place where we print a warning). This also means other repos can keep callingNewModuleReader(someDownloadClientFactory).