Add more tests for buf.work.yaml and normalize and validate DirPaths #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliversun9
commented
Nov 20, 2023
| if err := validateDirPathsNoOverlap(slicesextended.MapToSortedSlice(dirPathMap)); err != nil { | ||
| return err | ||
| // TODO: use this line: | ||
| // sortedNormalDirPaths := slicesextended.MapKeysToSortedSlice(normalDirPathToDirPath) |
bufdev
reviewed
Nov 20, 2023
| @@ -129,13 +129,13 @@ type bufWorkYAMLFile struct { | |||
| } | |||
|
|
|||
| func newBufWorkYAMLFile(fileVersion FileVersion, dirPaths []string) (*bufWorkYAMLFile, error) { | |||
| if err := validateBufWorkYAMLDirPaths(dirPaths); err != nil { | |||
| sortedNormalDirPaths, err := validateBufWorkYAMLDirPaths(dirPaths) | |||
There was a problem hiding this comment.
We've used normalized throughout rest of codebase, not normal, update
There was a problem hiding this comment.
fixed in f2481c7
fixed in 4ee426d |
bufdev
changed the title
bufdev
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for
buf_work_yaml_file.go.This PR also fixes a bug where
newBufWorkYAMLFiledoes not setdirPathsas the normalized input paths (but setdirPathsas the input paths as-is).