Add buf migrate command #2669
Merged
Add buf migrate command #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliversun9
commented
Dec 22, 2023
| "%s is a v1 generation template with a top-level 'types' section including %s. In a v2 generation template, 'types' can"+ | ||
| " only exist within an input in the 'inputs' section. Since the migration command does not have information"+ | ||
| " on inputs, the migrated generation will not have an 'inputs' section. To add these types in the migrated file, you can"+ | ||
| " first add an input to 'inputs' and then add these types to the input.", |
There was a problem hiding this comment.
Do you think this make sense? @doriable
bufdev
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes update to the migrate command:
buf beta migratetobuf migrate--moduleand--workspaceinstead of paths to those files.., unless--workspaceis specified but--moduleis not specified, in which case the destination is the directory for thatbuf.yaml.buf migrate --workspace foo/bar, then the newbuf.yamlwill be written atfoo/bar/buf.yaml../buf.yamlwill be written.--template, allowing multiple paths to buf.gen.yamls.Note: with the recent change on reading a lock file without digest. Right now
buf migratefails withFailure: unimplementedif there is a buf.lock to write. It shouldn't fail once commit service has been implemented.