-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v2
modules to integration tests
#2682
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love some tests added to probably buflint_test.go
that test the new ignore_only paths being relative to the buf.yaml instead of being root-relative, and some tests that test excludes per directory in these integration tests, does that make sense/could you add those?
Also, are there any tests checking how |
v2
modules to buf/cmd/buf integration testsv2
modules to integration tests
So there currently is a test that inlines buf/private/buf/cmd/buf/workspace_test.go Lines 189 to 207 in 4b7b26d
|
@@ -1109,30 +1168,40 @@ func testLintWithOptions( | |||
storageos.ReadWriteBucketWithSymlinksIfSupported(), | |||
) | |||
require.NoError(t, err) | |||
var options []bufworkspace.WorkspaceBucketOption |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isnt used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, I ended up going with targeting the opaque IDs instead
) | ||
require.NoError(t, err) | ||
|
||
if moduleFullNameString == "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to:
opaqueID := moduleFullNameString
if opaqueID == "" {
opaqueID = "."
}
@@ -190,6 +190,40 @@ func ModuleSetToDAG(moduleSet ModuleSet) (*dag.Graph[string], error) { | |||
return graph, nil | |||
} | |||
|
|||
// ModuleToSelfContainedModuleReadBucketWithOnlyProtoFiles converts the Module to a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this move?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I think I moved this by accident while traversing some of the helpers. Moved it back.
This adds
v2
modules to allbuf/cmd/buf
workspace and lint integration tests.It also covers a couple of a bit of clean-up around error messages.