Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a script to collect all bufmod TODOs #2708

Merged
merged 5 commits into from
Jan 18, 2024
Merged

Create a script to collect all bufmod TODOs #2708

merged 5 commits into from
Jan 18, 2024

Conversation

doriable
Copy link
Member

This is a script for collecting all TODOs on bufmod that are
not on main. Sample output:

private/bufpkg/bufmodule/remote_dep.go: 44 // TODO: This needs a LOT of testing.
private/pkg/connectclient/connectclient.go: 21 // TODO: eliminate config, just make the below MakeOptions, add httpClient as a parameter to Make
private/pkg/dag/graph.go: 45 // TODO: It really stinks that we have to use the constructor. We have what amounts
private/pkg/slicesext/slicesext.go: 146 // TODO: Delete this in favor of slices.Clone.
private/pkg/slicesext/slicesext.go: 166 // TODO: Make ToStructMap use this logic, remove ToStructMapOmitEmpty, to match other functions.
private/pkg/slicesext/slicesext.go: 315 // TODO: Replace with slices.Sort when we only support Go versions >= 1.21.
private/pkg/syncext/syncext.go: 25 // TODO: This is directly copied from 1.21 source, remove when no longer need <1.20.
private/pkg/syncext/syncext.go: 57 // TODO: This is directly copied from 1.21 source, remove when no longer need <1.20.

@doriable doriable requested a review from bufdev January 17, 2024 02:38
@doriable
Copy link
Member Author

@bufdev I wasn't sure if we wanted to put this as a part of make generate, I didn't want to inadvertently cause CI issues by doing that. It seems reasonable to generate and/use on an ad-hoc basis for now but yeah, let me know what you think.

@bufdev
Copy link
Member

bufdev commented Jan 17, 2024

This script still has bugs, example:

586:					// TODO: sweep and check paths gone: 593 // TODO: add default values
586:					// TODO: sweep and check paths gone: 773 // TODO in v2

@doriable doriable requested a review from bufdev January 17, 2024 23:39
@doriable doriable merged commit bef8ce9 into bufmod Jan 18, 2024
6 of 7 checks passed
@doriable doriable deleted the collect-todos branch January 18, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants