Fix panic in buf curl
that can happen with some map fields
#2711
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
-v
is used, the command shows the amount of unrecognized data in the response. When it counts that data, a bug in one of thecase
expressions allowed it to fall into the wrong case (for a map whose values are not messages). This would then result in a panic:The panic actually happens whether or not the user includes a
-v
option, since this part of the code calculates and prints the value unconditionally. (If-v
is not specified, the "print" step is effectively a no-op.)This branch fixes that panic and adds a test. The test uses a message with fields of every possible type (including groups) to make sure that all types are correctly handled without panic. The test reproduces the panic issue, and confirms the fix.