Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InvalidRemoteErr panic #2728

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Conversation

emcfarlane
Copy link
Contributor

@emcfarlane emcfarlane commented Jan 24, 2024

On an unknown remote ModuleIdentity may be nil. Use the fallback logic to select the correct dependency and derive the related module identity. Fixes #2725

A dial error for an invalid host will now correctly return the error formatted with a prompt to check the registry:

Failure: dial tcp: lookup private.registry: no such host. Are you sure "private.registry" (derived from module name "private.registry/org/dependency") is a Buf Schema Registry?

On an unknown remote ModuleIdentity may be nil. Use the fallback logic
to select the correct dependency and derive the related module
identity. Fixes bufbuild#2725
@emcfarlane emcfarlane marked this pull request as ready for review January 24, 2024 17:31
@emcfarlane emcfarlane merged commit 4b8e791 into bufbuild:main Jan 24, 2024
2 checks passed
@emcfarlane emcfarlane deleted the ed/fixInvalidRemoteErr branch January 24, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mod update panics when dependencies are from multiple registries
4 participants