Check for duplicate files on Build #2751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build on a ModuleSetBuilder will now fail with a duplicate error if a module contains the same file path for a proto file as another module. A new error type DuplicatePathError will be returned.
saquibmian
reviewed
Feb 5, 2024
| // Validate all proto files are unique. | ||
| filePathToModule := make(map[string]Module, len(modules)) | ||
| for _, module := range modules { | ||
| if err := module.WalkFileInfos(ctx, func(fileInfo FileInfo) error { |
There was a problem hiding this comment.
This is going to force a load of the ModuleData for this Module, which we don't want to do.
I'm forgetting now, which layer did we do this in the past? It must have been close to Image construction time.
|
Closing, moving to BSR layer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build on a ModuleSetBuilder will now fail with a duplicate error if a module contains the same file path for a proto file as another module. A new error type
DuplicatePathErrorwill be returned.