Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add support for #validate=true to message refs (#2633)" #2755

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Revert "Add support for #validate=true to message refs (#2633)" #2755

merged 1 commit into from
Feb 8, 2024

Conversation

bufdev
Copy link
Member

@bufdev bufdev commented Feb 8, 2024

Reverts #2633. We want to limit this to just buf convert --from - there's no usecase otherwise (no need to validate --to, and Images do not use protovalidate).

@bufdev bufdev merged commit c088255 into main Feb 8, 2024
8 checks passed
@bufdev bufdev deleted the revert-validate branch February 8, 2024 18:31
@bufdev bufdev mentioned this pull request Feb 8, 2024
Merged
bufdev added a commit that referenced this pull request Feb 8, 2024
@bufdev
Add buf convert --validate (#2756)
0814191 
Follow-up to #2633 and
#2755.

This adds a flag `buf convert --validate` to validate incoming messages
specified with `--from` using protovalidate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bufdev