Add audit logging resource and events for check plugin #3430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
mfridman
reviewed
Oct 29, 2024
| @@ -115,6 +116,8 @@ enum EventType { | |||
| EVENT_TYPE_USER_AUTO_MERGED_FROM_NEW_IDP = 37; | |||
| EVENT_TYPE_DEVICE_AUTHORIZATION_GRANT_APPROVED = 41; | |||
| EVENT_TYPE_DEVICE_AUTHORIZATION_GRANT_DENIED = 42; | |||
| EVENT_TYPE_CHECK_PLUGIN_CREATED = 43; | |||
There was a problem hiding this comment.
Why wouldn't this be a "plugin created" and then on the payload plugin created you have a "type" to represent the plugin type? It's all one action against the same RPC.
There was a problem hiding this comment.
updated, we will be reusing the resource and event type of alpha plugin then
bufdev
approved these changes
Oct 29, 2024
bufdev
approved these changes
Oct 29, 2024
mfridman
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this add the necessary audit logging types and events for the check plugin works