Bug: Leading slash for type urls

[grod220]

I have a grpc query that returns a field with a google.protobuf.Any. At runtime it has the type url of: /ibc.lightclients.tendermint.v1.ClientState

The corresponding message it represents has the type url of: type.googleapis.com/ibc.lightclients.tendermint.v1.ClientState.

The discrepancy of type urls makes our registry not able to match these during the Any unpacking. Here is the logic that converts type urls to type names:

protobuf-es/packages/protobuf-test/src/gen/js/google/protobuf/any_pb.js

Line 211 in f7375ad

const name = slash > 0 ? url.substring(slash + 1) : url;

This logic gives us:

Url: /ibc.lightclients.tendermint.v1.ClientState
Name: /ibc.lightclients.tendermint.v1.ClientState

Url: type.googleapis.com/ibc.lightclients.tendermint.v1.ClientState
Name: ibc.lightclients.tendermint.v1.ClientState

No match ❌

Can Any.prototype.typeUrlToName be expanded to handle leading slashes?

[timostamm]

The implementation assumes that type_url is a valid URL (optionally omitting the scheme) based on the documentation.

But it doesn't hurt to relax this a bit and accept just a leading slash. I just checked the Go implementation, and it also accepts this form.

[grod220]

Opened a PR, thanks for the review 🙏