Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match typeUrls with leading slash in google.protobuf.Any #618

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

grod220
Copy link
Contributor

@grod220 grod220 commented Nov 16, 2023

Closes #617

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and the tests!

The Any class is actually generated by protoc-gen-es. Can you apply the change to the following two places in the plugin?

f.print(" const name = slash > 0 ? url.substring(slash + 1) : url;");

f.print(" const name = slash > 0 ? url.substring(slash + 1) : url;");

Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@timostamm timostamm changed the title Match typeUrls with leading slash Match typeUrls with leading slash in google.protobuf.Any Nov 17, 2023
@timostamm timostamm merged commit 9777c0b into bufbuild:main Nov 17, 2023
5 checks passed
@grod220
Copy link
Contributor Author

grod220 commented Nov 17, 2023

Thanks for being so quick and responsive! 🎊

@grod220 grod220 deleted the leading-slash branch November 17, 2023 11:04
@grod220
Copy link
Contributor Author

grod220 commented Nov 30, 2023

Do you think it's possible to get a release sometime this week? :)

@timostamm timostamm mentioned this pull request Nov 30, 2023
@timostamm
Copy link
Member

Just released in v1.5.0 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Leading slash for type urls
3 participants