Make edition feature defaults from protoc available
#615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
commented
Nov 16, 2023
| import { FileDescriptorSet, proto3, ScalarType } from "@bufbuild/protobuf"; | ||
| import { UpstreamProtobuf } from "upstream-protobuf"; |
There was a problem hiding this comment.
Since we're here, I've also added the compileToDescriptorSet method, which gives us the generic option to generate descriptors from inline protobuf source, and makes this test a bit more readable.
… into tstamm/edition-feature-defaults
Welp. I split the noisy formatter fixes into separate PRs for a better commit history 😐 Yes, this was supposed to be just e16130a. |
smaye81
approved these changes
Nov 16, 2023
This was referenced Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent release v25 of
protocmakes edition feature resolution available via a flag:--experimental_edition_defaults_outoutputs a google.protobuf.FeatureSetDefaults message, which can be used to seed feature resolution.This PR adds functionality to the internal upstream-protobuf package to make it easy to shell out to
protoc, and to generate the defaults.