Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proto package names should not be mixed in the same directory #89

Closed
zanes2016 opened this issue Jul 31, 2018 · 2 comments
Closed

proto package names should not be mixed in the same directory #89

zanes2016 opened this issue Jul 31, 2018 · 2 comments
Labels
Bug Reports and/or fixes a bug

Comments

@zanes2016
Copy link

zanes2016 commented Jul 31, 2018 •
edited
Loading

We're getting a PGV error in envoyproxy/envoy#3949 (comment) of the following:

proto package names should not be mixed in the same directory

This check exists at https://github.com/lyft/protoc-gen-star/blob/f3b83fca61817e55058744eb1a3c8e2e95a0dada/gatherer.go#L114.

Is there a way to turn this check off?
@rodaine
Copy link
Member

rodaine commented Aug 6, 2018

Hi @zanes2016 it's a limitation of protoc-gen-go, which protoc-gen-validate is built on top of (via protoc-gen-star). I'm currently working on changes to protoc-gen-star that addresses this.

@moderation moderation mentioned this issue Aug 22, 2018
Closed
@rodaine rodaine added the Bug Reports and/or fixes a bug label Aug 30, 2018
@moderation moderation mentioned this issue Aug 30, 2018
Merged
@sesmith177 sesmith177 mentioned this issue Aug 31, 2018
Closed
@sesmith177 sesmith177 mentioned this issue Sep 19, 2018
Closed
@rodaine rodaine mentioned this issue Sep 26, 2018
Merged
@rmichela
Copy link
Contributor

Is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Reports and/or fixes a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rmichela @rodaine @elliotmjackson @zanes2016