Fix Bazel build by generating proto code automatically #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the gogo proto toolchain to generate PGV validations for proto files that are accessible as Bazel targets.
Instead of requiring the libraries to be generated via make or manually, use Bazel to auto-generate them when needed.
This commit brings these into compliance with Bazel naming conventions: for a file xyz.proto: - xyz_proto is a proto_library target for xyz.proto - xyz_go_proto is a go_proto_library target for xyz.proto - xyz_cc_proto is a cc_proto_library target for xyz.proto
Using the vendored version causes problems since the two versions aren't completely interchangeable, and gogo generates proto code using the Bazel-referenced one.
rodaine
approved these changes
Aug 21, 2018
|
I was going to take a stab at using this commit in Envoy but will defer until #89 is addressed. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test code depends on auto-generated Go code that, if missing, will cause compilation errors. This can be generated via
make, but doing soThis PR updates the Bazel rules and targets so that
bazel run //tests/harness/executorworks again and runs the full test suite. The changes are limited to BUILD files (there are no code changes) so it should only affect Bazel-based builds.