add support for multiple plugins #717
Conversation
Instead of requiring a 'lang' option to be specified, create separate binaries configured to output code for a given language.
pkwarren
force-pushed
the
pkw/multiple-plugins
branch
from
741f036
to
e6f0693
Compare
| @@ -1,3 +1,4 @@ | |||
| .git/ | |||
| .idea/ | |||
| .bin/ | |||
| dist/ | |||
There was a problem hiding this comment.
Used by goreleaser (tested it locally to ensure it built all binaries).
| @@ -1,3 +1,4 @@ | |||
| # yaml-language-server: $schema=https://json.schemastore.org/github-workflow.json | |||
There was a problem hiding this comment.
This file was being identified as both a github workflow and a goreleaser config file in vscode - this will remove invalid flagged errors when editing this file.
| # python tooling for linting and uploading to PyPI | ||
| COPY requirements.txt . |
There was a problem hiding this comment.
Optimized the docker build to benefit from layer caching so we don't re-download the Python dependencies if any other files change.
| @@ -1,107 +0,0 @@ | |||
| # This file is autogenerated, do not edit; changes may be undone by the next 'dep ensure'. | |||
There was a problem hiding this comment.
This project is using Go modules - removed the Gopkg.* files used by dep.
| @@ -25,7 +25,7 @@ build: validate/validate.pb.go ## generates the PGV binary and installs it into | |||
|
|
|||
| .PHONY: bazel | |||
| bazel: ## generate the PGV plugin with Bazel | |||
| bazel build //tests/... | |||
| bazel build //cmd/... //tests/... | |||
There was a problem hiding this comment.
Verifies that the new commands can build w/ bazel.
| optional := uint64(pluginpb.CodeGeneratorResponse_FEATURE_PROTO3_OPTIONAL) | ||
| pgs. | ||
| Init(pgs.DebugEnv("DEBUG_PGV"), pgs.SupportedFeatures(&optional)). | ||
| RegisterModule(module.ValidatorForLanguage("cc")). |
There was a problem hiding this comment.
This is the main change (along with removing RegisterPostProcessor(pgsgo.GoFmt()). for non-Go generators).
| @@ -73,6 +74,7 @@ | |||
| <artifactId>maven-compiler-plugin</artifactId> | |||
| <version>3.10.1</version> | |||
| <configuration> | |||
| <release>${java.release}</release> | |||
There was a problem hiding this comment.
This ensures that not only are source/target bytecode compatible with Java 8, but it also builds with the Java 8 bootclasspath to ensure no APIs introduced in Java 9+ are accidentally pulled in. It is supported by Java compilers 9+ (we are building with 17 as part of CI).
Ref: https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#release
Instead of requiring a 'lang' option to be specified, create separate
binaries configured to output code for a given language.