Upgrade bazelbuild rules_go to latest release: 0.13.0 #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 24, 2018 22:52
|
I've signed the CLA, not sure why it's not reflecting that. |
|
Also see deprecations in the release notes: https://github.com/bazelbuild/rules_go/blob/0.13.0/deprecation.rst |
|
Looks like this requires modifying the Skylark rules in file bazel/go_proto_library.bzl Somehow we need to change the reference from I'm not too familiar with the Bazel Skylark language. It would be much appreciated if someone has any quick suggestions. |
Merged
|
This is a duplicate of #87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to upgrade to 0.13.0 to pick up bug fixes and compatibility issues. Also see envoyproxy/envoy#3949 (comment)