Runtime: Core BPF Migration: Path to migrate a builtin to Core BPF (s…

…olana-labs#408)

* runtime: core_bpf_migration: add migration path

* runtime: core_bpf_migration: add tests for migration path

* comments

* function name

* rent lamports

* bank operations ordering

* make migration method a bank method

* update deployment slot to current slot

* invoke loader deploy directly

programs/bpf_loader/src/lib.rs

@@ -168,6 +168,29 @@ macro_rules! deploy_program {
     }};
 }
 
+/// Directly deploy a program using a provided invoke context.
+/// This function should only be invoked from the runtime, since it does not
+/// provide any account loads or checks.
+pub fn direct_deploy_program(
+    invoke_context: &mut InvokeContext,
+    program_id: &Pubkey,
+    loader_key: &Pubkey,
+    account_size: usize,
+    elf: &[u8],
+    slot: Slot,
+) -> Result<(), InstructionError> {
+    deploy_program!(
+        invoke_context,
+        *program_id,
+        loader_key,
+        account_size,
+        slot,
+        {},
+        elf,
+    );
+    Ok(())
+}
+
 fn write_program_data(
     program_data_offset: usize,
     bytes: &[u8],

runtime/src/bank/builtins/core_bpf_migration/error.rs

@@ -1,8 +1,14 @@
-use {solana_sdk::pubkey::Pubkey, thiserror::Error};
+use {
+    solana_sdk::{instruction::InstructionError, pubkey::Pubkey},
+    thiserror::Error,
+};
 
 /// Errors returned by a Core BPF migration.
 #[derive(Debug, Error)]
 pub enum CoreBpfMigrationError {
+    /// Solana instruction error
+    #[error("Solana instruction error: {0:?}")]
+    InstructionError(#[from] InstructionError),
     /// Bincode serialization error
     #[error("Bincode serialization error: {0:?}")]
     BincodeError(#[from] bincode::Error),