Commit homework 4 update #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,31 +18,66 @@ public static void init() { | |||
| } | |||
|
|
|||
| @Test | |||
| public void testGetDaytimeType() { | |||
| public void testGetDaytimeType_night_boundCase_1() { | |||
There was a problem hiding this comment.
I like this separated tests here. Very much :)
One minor recommendation here - try to not use indexes in test names. You still can make it more meaningful without it. As example this test can be called "testGetDaytimeTypeNightLowerBound" or even better - when_zero_oclock_then_return_night.
|
Steven, let me come to your desk tomorrow morning. I'm not sure what is changed here after I saw it last time in the office. In any case I'm glad you spend long time on this task and learn a lot during debuging and troubleshooting That how we become better developers, right? ;) |
It's for Cache practice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.