Add webm to importing extensions #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Line was previously touched in #208.) |
pajowu
approved these changes
Feb 22, 2022
|
LGTM, @anuejn feel free to merge if it looks good to you as well |
|
Thank you a lot for the Pull Request, we really appreciate it. This should be the right line. One issue we now have: While most formats supported in webm (vp9, opus, vorbis) are supported by mp4, webm also supports vp8, which mp4 doesn't. This breaks our automatic conversion from all file formats to mp4. We should check whether webm can be considered a "safe" file format as well. I added a new issue #329 for this |
anuejn
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #327.
Untested, as you can probably guess from the
patch-1branch name 😅 but it sure looks like this is the relevant code.