Do not split render items on speaker change #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does Otio export really not work at all? I thought I tested at least some output formats sucessfully (kdenlive maybe?). |
pajowu
force-pushed
the
pajowu/continous_renderitems
branch
from
85486dc
to
b4b9431
Compare
This leads to smoother playback and better exported files.
pajowu
force-pushed
the
pajowu/continous_renderitems
branch
from
b4b9431
to
dcc59d4
Compare
|
I re-did the PR using a flag on the |
anuejn
approved these changes
Oct 13, 2022
|
thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
removes the otio export, which doesn't work properly at the moment. This allows us to changeadds a flag to therenderItemsselector to ignore speaker changes and only care about source changes. Doing that results in less "crackling" during playback and in the exported files, which previously occured everytime the speaker changes.