Fix replay of files with malformed records #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases recorded files contain small amount malformed records. The root cause is not clear, maybe multiple processes writing to the same file. This change ensuer that file can be replayed, and malformed records will be ingored (with meaningful debug message showing exact line in the file with issue). Additionally `--input-file-dry-run` mode was speed up a bit, since there were a few of Sleep statements which were not ignored when dry run is executed.
houndci-bot
reviewed
Oct 6, 2021
input_file.go
Outdated
| for { | ||
| line, err := f.reader.ReadBytes('\n') | ||
| lineNum += 1 |
There was a problem hiding this comment.
should replace lineNum += 1 with lineNum++
buger
changed the title
|
2 Issues
|
|
Kudos, SonarCloud Quality Gate passed!
|
buger
added a commit
that referenced
this pull request
Oct 6, 2021
In some cases recorded files contain small amount malformed records. The root cause is not clear, maybe multiple processes writing to the same file. This change ensuer that file can be replayed, and malformed records will be ingored (with meaningful debug message showing exact line in the file with issue). Additionally `--input-file-dry-run` mode was speed up a bit, since there were a few of Sleep statements which were not ignored when dry run is executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases recorded files contain small amount malformed records.
The root cause is not clear, maybe multiple processes writing to the same file.
This change ensuer that file can be replayed, and malformed records will be ingored (with meaningful debug message showing exact line in the file with issue).
Additionally
--input-file-dry-runmode was speed up a bit, since there were a few of Sleep statements which were not ignored when dry run is executed.