fix sets multiple --output-http parameters to take effect only one #1097

byte0o · 2022-07-09T11:44:13Z

This function is called when the outhttp plugin is registered in the loop, passing a pointer type to &Settings.OutputHTTPConfig
https://github.com/buger/goreplay/blob/master/plugins.go#L145
for _, options := range Settings.OutputHTTP { plugins.registerPlugin(NewHTTPOutput, options, &Settings.OutputHTTPConfig) }

parsing the address to generate the url directly overrides the &Settings.OutputHTTPConfig.url field,which will cause multiple calls to overwrite the same &Settings.OutputHTTPConfig.url field
https://github.com/buger/goreplay/blob/master/output_http.go#L71
config.url, err = url.Parse(address)

Multiple HTTPOutputs point to the same &Settings.OutputHTTPConfig, resulting in the last --output-http parameter value overwriting the previously set value.
https://github.com/buger/goreplay/blob/master/output_http.go#L106
o.config = config

houndci-bot · 2022-07-09T11:44:16Z

output_http.go

@@ -48,6 +48,24 @@ type HTTPOutputConfig struct {
 	url            *url.URL
 }

+func (hoc *HTTPOutputConfig) Copy() *HTTPOutputConfig {


exported method HTTPOutputConfig.Copy should have comment or be unexported

CLAassistant · 2022-07-09T11:44:17Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}