Fix Expect: 100-continue requests and refactor chunked encoding #158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expect: 100-continue
Requests with Expect: 100-continue use 2 tcp messages instead of 1: first waits for confirmation from server, second sends data.
Since Gor use simple TCP parser and assumption that every request should be send using single message, it did not worked.
I added special case, when it sees 100-continue request, it will wait for tcp message containing data, and will merge those messages (removing 100-continue request at all).
Chunked encoding handling moved to TCPMessage
Support for chunked encoding was added few days ago, but it worked inside HTTPOutput plugin.
I moved to TCPMessage, so it normalize all HTTP requests, and any output (including file), will see simple POST request without chunk encoding.
Other notes
Should fix #71 and #77