Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to configure timeout #183

Merged
merged 2 commits into from
Jul 31, 2015
Merged

Option to configure timeout #183

merged 2 commits into from
Jul 31, 2015

Conversation

buger
Copy link
Owner

@buger buger commented Jul 31, 2015

Now you can configure http-output timeout with --output-http-timeout 30s. By default it is 5s.

buger added a commit that referenced this pull request Jul 31, 2015
@buger buger merged commit 00ad6bd into master Jul 31, 2015
@ahsandar
Copy link

ahsandar commented Aug 6, 2015

when can the binaries be available for download ? any estimate

@buger
Copy link
Owner Author

buger commented Aug 6, 2015

@ahsandar
Copy link

ahsandar commented Aug 6, 2015

cheers

@buger
Copy link
Owner Author

buger commented Aug 6, 2015

Included into v0.9.8

@zhaitianduo
Copy link

Hi, I've added "--output-httout 30s" in the replay command. But I'm still seeing many timeout when replaying the requests. Server response time must be less than 30s. Do you have any clue on this?
command:
I'm using 30x speed. Command is:
sudo ./gor --input-file "requests.gor|3000%" --output-http="xxx.xxx.net:9071" --output-http-timeout 30s

Thanks

@buger
Copy link
Owner Author

buger commented Jun 8, 2016

@ztd9071 can it be that your server can't handle such load and just dropping requests or hang more then for 30s? Also can you give output of running command above with: --stats --output-http-stats flags.

Thank you!

@zhaitianduo
Copy link

@buger Thanks for checking this. I will double check if the requests are dropped by server side, I will try using --stats flag to see what happened.

Thank you!

@zhaitianduo
Copy link

@buger Another question for you. I've dumped 30 minutes' requests from server. When I replayed using 300x speed, I didn't find the replay ends in 6 seconds. Is there a speed limit when replay?

Thanks

@zhaitianduo
Copy link

Hi,
I've checked the server again but I didn't find any connection limit.
Put more information here to see if you can help.

2016/06/12 09:37:27 [HTTPClient] Connection error: dial tcp x.x.x.x:9071: i/o timeout

stats:
2016/06/12 09:37:31 output_http:0,351,809,3763,752,2431 2016/06/12 09:37:36 output_http:1000,999,1000,3450,690,2317 2016/06/12 09:37:41 output_http:1000,999,1000,1504,300,2317 2016/06/12 09:37:46 output_http:1000,999,1000,1291,258,2317 2016/06/12 09:37:51 output_http:1000,999,1000,1256,251,2317 2016/06/12 09:37:56 output_http:1000,999,1000,1222,244,2317 2016/06/12 09:38:01 output_http:1000,999,1000,1255,251,2317 2016/06/12 09:38:06 output_http:1000,999,1000,1181,236,2317 2016/06/12 09:38:11 output_http:1000,999,1000,1145,229,2317 2016/06/12 09:38:16 output_http:1000,999,1000,1140,228,2317 2016/06/12 09:38:21 output_http:1000,999,1000,1055,211,2317 2016/06/12 09:38:26 output_http:1000,999,1000,1113,222,2317 2016/06/12 09:38:31 output_http:1000,999,1000,1049,209,2317 2016/06/12 09:38:36 output_http:1000,999,1000,932,186,2317 2016/06/12 09:38:41 output_http:1000,999,1000,1060,212,2317 2016/06/12 09:38:46 output_http:1000,999,1000,1004,200,2317 2016/06/12 09:38:51 output_http:989,994,1000,836,167,2317 2016/06/12 09:38:56 output_http:1000,999,1000,1079,215,2317 2016/06/12 09:39:01 output_http:1000,999,1000,975,195,2317 2016/06/12 09:39:06 output_http:1000,999,1000,1031,206,2317 2016/06/12 09:39:11 output_http:1000,999,1000,987,197,2317

Thank you!

@buger
Copy link
Owner Author

buger commented Jun 12, 2016

Thank you, can you try this binary?

gor_connection-timeout-fix_x64.tar.gz

The main change is that previously when you were setting timeout option; it was affecting only "read" timeout, but not "connection" timeout (which was one second by default). Now it set both timeouts.

I've dumped 30 minutes' requests from the server. When I replayed using 300x speed, I didn't find the replay ends in 6 seconds. Is there a speed limit when replay?

There is no any limit, only your hardware, and tested app.

@zhaitianduo
Copy link

Thank you!

@buger
Copy link
Owner Author

buger commented Jun 12, 2016

Tell me if it fixed the problem, thanks!

@zhaitianduo
Copy link

Hi @buger
Yes, the timeout issue is fixed.
And about the speed limit question, I found the speed is limited by bandwidth.

Thank you!

@slimus slimus deleted the configurable-timeout branch June 3, 2020 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants