Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close http.Response.Body to avoid http connection and goroutine leak. #927

Merged
merged 1 commit into from
May 21, 2021
Merged

Close http.Response.Body to avoid http connection and goroutine leak. #927

merged 1 commit into from
May 21, 2021

Conversation

code4wt
Copy link
Contributor

@code4wt code4wt commented May 16, 2021 •
edited
Loading

fix #926

@CLAassistant
Copy link

CLAassistant commented May 16, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

urbanishimwe
urbanishimwe reviewed May 17, 2021
View reviewed changes
Copy link
Collaborator

@urbanishimwe urbanishimwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not about issue #926 check #926 (comment) for more context

output_http.go Show resolved Hide resolved
@buger
Copy link
Owner

buger commented May 21, 2021

This totally makes sense!

@buger buger merged commit 22f0b09 into buger:master May 21, 2021
xingren23 referenced this pull request in xingren23/goreplay Sep 4, 2021
@code4wt
Close http.Response.Body to avoid http connection leak. (#927)
898f4d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urbanishimwe urbanishimwe urbanishimwe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GoReplay v1.3.0_RC1 has goroutine leak when replaying traffic
4 participants
@code4wt @CLAassistant @buger @urbanishimwe