Bugfix: Test Connections before Returning them from ConnectionPool. #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the time the connection was originally created, many problems may have occurred, including a network outage, server restart, timeout, and many other possibilities. In order to prevent these temporary errors from permanently causing connections returned by the ConnectionPool, test the connection before returning it to the user. In order to prevent inordinate delays, e.g. the first connection to be made after 100 connections had previously been made, only 1 connection will be tested before creating a new one. Fixes: buggins#124.
SingingBush
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the time the connection was originally created, many problems may have occurred, including a network outage, server restart, timeout, and many other possibilities. In order to prevent these temporary errors from permanently causing connections returned by the ConnectionPool, test the connection before returning it to the user.
In order to prevent inordinate delays, e.g. the first connection to be made after 100 connections had previously been made, only 1 connection will be tested before creating a new one.
Fixes: #124.