Feat/api_plugin_nodemailer_with_microsoft_authentication nodemailer update #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- email regex is lenient and hence auto-generation can be excessive! - work-around, specify email values in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: upgrade nodemailer to resolve reactioncommerce#1584
Resolves nodemailer/nodemailer#1584
Impact: minor
Type: bugfix
Issue
User and pass were previously required when providing a custom authentication function.
Solution
The hack to circumvent the bug is now removed and the behavior is as expected.
If you're solving a UIX related issue, please attach screen-caps or gifs showing how your solution differs from the issue.