Upgrade repo to lerna v8 and Node 18 #2209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yousif-bugsnag
force-pushed
the
lerna-bump
branch
7 times, most recently
from
0fe8966
to
93c1808
Compare
yousif-bugsnag
force-pushed
the
lerna-bump
branch
9 times, most recently
from
5e919ec
to
8d9bb90
Compare
yousif-bugsnag
force-pushed
the
lerna-bump
branch
from
8d9bb90
to
ace7783
Compare
gingerbenw
commented
Oct 1, 2024
Comment on lines
-128
to
-130
| - ie_8 | ||
| - ie_9 | ||
| - ie_10 |
| @@ -23,6 +23,6 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@bugsnag/core": "^8.0.0", | |||
| "@types/koa": "^2.11.3" | |||
| "@types/koa": "2.13.4" | |||
There was a problem hiding this comment.
is this pinned due to an issue with unit testing? would be good to add a task to update this and validate it
There was a problem hiding this comment.
it's pinned to the latest version compatible with our current typescript version - this can be reviewed if/when we upgrade typescript
|
I raised this PR so I can't directly approve it - but I'm happy with the changes so feel free to Approve. 👍🏻 |
|
Failing PR diff bot test is caused by the removal of the Lerna bootstrap command and should be fine for the next PR |
|
force-merging with expected PR diff bot failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Upgrades the lerna version from v4 to v8, and upgrades the repo to use Node 18 for devlopment (required by lerna v8)
Design
Upgrading lerna to v8 means removing the deprecated bootstrap command and switching to npm workspaces, which in turn means that packages are now installed into the top-level node_modules directory. Many of the changes within the individual packages are dealing with the fallout of this in order to fix linting, unit tests and typescript errors.
All CI dockerfiles and steps that build the packages also had to be upgraded to node 18 as a result.
Changeset
@types/*packages to maintain compatibility with the current typescript versionTesting
Covered by a full CI run