Remove lock files and fix internal peer deps in packages #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Removes
package-lock.jsonfiles from individual packagesAlso Updates internal peer dependencies for packages to point to
^8.0.0rather than^8.0.0-alpha.1.Design
As the repo now uses npm workspaces, dependencies are listed in the root package-lock.json and individual lock files are no longer required.
The
legacy-peer-depsflag has also been reinstated for React Native test fixture builds. This ensures that test fixtures don't pull in multiple versions of bugsnag packages when published to local/private repos - lerna doesn't update peer deps when publishing, so without this both the peer depenendency version (e.g.8.0.0) and the locally published version (e.g.8.0.0-ci-my-branch.12345) would be installed.Testing
Covered by a full CI run