Skip to content

Commit

Permalink
Rename @npm to @com_github_buildbarn_bb_storage_npm
Browse files Browse the repository at this point in the history
The name 'npm' is a bit too generic and will end up causing conflicts if
this repo is used as a dependency inside another. We also want to make
sure to set 'link_workspace'. It's not possible for us to use @// inside
of a module.
  • Loading branch information
EdSchouten committed Mar 30, 2024
1 parent 2053804 commit 61ca725
Show file tree
Hide file tree
Showing 4 changed files with 463 additions and 461 deletions.
2 changes: 1 addition & 1 deletion BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
load("@com_github_bazelbuild_buildtools//buildifier:def.bzl", "buildifier")
load("@com_github_buildbarn_bb_storage_npm//:defs.bzl", "npm_link_all_packages")
load("@gazelle//:def.bzl", "gazelle")
load("@npm//:defs.bzl", "npm_link_all_packages")

# gazelle:go_grpc_compilers @rules_go//proto:go_grpc
# gazelle:prefix github.com/buildbarn/bb-storage
Expand Down
5 changes: 3 additions & 2 deletions MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,11 @@ use_repo(llvm, "llvm_toolchain_llvm")

npm = use_extension("@aspect_rules_js//npm:extensions.bzl", "npm")
npm.npm_translate_lock(
name = "npm",
name = "com_github_buildbarn_bb_storage_npm",
link_workspace = "com_github_buildbarn_bb_storage",
pnpm_lock = "//:pnpm-lock.yaml",
)
use_repo(npm, "npm")
use_repo(npm, "com_github_buildbarn_bb_storage_npm")

oci = use_extension("@rules_oci//oci:extensions.bzl", "oci")
oci.pull(
Expand Down
Loading

0 comments on commit 61ca725

Please sign in to comment.