Add a configurable scale factor to scale in/out #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@etaoins would love to hear your thoughts! |
etaoins
approved these changes
May 5, 2019
| return "", err | ||
| } | ||
| scaleInFactor = math.Abs(scaleInFactor) |
| factoredChange := int64(math.Floor(float64(change) * factor)) | ||
|
|
||
| if factoredChange < change { | ||
| log.Printf("👮️ Increasing scale-in of %d by factor of %0.2f", |
There was a problem hiding this comment.
I'm not sure about the utility of having a scale-in factor >100% but if someone is crazy enough to configure that I guess we should honour it.
There was a problem hiding this comment.
Yeah, I thought the same 🤷🏼♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a scale-in and scale-out factor that can be used to speed up or slow down scale outs and ins.
For instance, setting
SCALE_IN_FACTOR=0.5will reduce the change applied in each scale in by 50%. SettingSCALE_OUT_FACTOR=2.0will increase each scale out change by 200%.This is a simpler take on #12.