Use AWS shared credentials config #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the code creates a new session.Session for every invocation. This change pulls out that session as a dependency that gets passed into the various things that invoke it.
This looks for a credentials file in the aws sdk
keithduncan
approved these changes
Jul 13, 2021
There was a problem hiding this comment.
I wonder whether we should just have this on all the time for the local main.go as the SDK still preferences the environment variables. We’d still use the environment variables from something like aws-vault even if you have a ~/.aws/config.
Looks good either way to me!
|
Realised after approving that you can’t hit the merge button here, let me know what you think about making this always-on vs a flag then I can merge or we’ll tweak it and merge 🙇♂️ |
|
Yeah, after some thought just as a default makes sense. |
|
I'd suggest merge and squash for this one to remove the confusing history! |
keithduncan
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables shared config checks in the AWS Session SDK for setups that use
~/.aws/credentials. See https://docs.aws.amazon.com/sdk-for-go/v1/developer-guide/configuring-sdk.htmlNote that 508764a makes a change where by a single session is used and passed around vs
session.New()invoked everywhere. It's remotely possible this could break things where creating a new session each time was providing some durability around failures and dropouts unintentionally. I don't think this is likely, as there are internal retry mechanisms in the single session. In fact, I think that it's likely that establishing lots of new sessions could lead to rate-limiting and latency.