Allow the event schedule rate to be configured via parameters #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @triarius , Cheers |
triarius
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is being raised to allow the Event Schedule rate to be configurable via Parameter inputs.
There is a Default value provided to ensure the change is backwards compatible.
Reason for the change
When there are a large number of BuildKite agent queues combined with other resources such as Cluster Autoscalers the AWS API for
DescribeAutoScalingGroupsInforeceives aThrottlingException. This has a negative impact on all services that are required to interact with the AWS Autoscaling API.This PR will allow for the schedule to be updated as required to ensure throttling exceptions are not triggered.
If this PR is merged, another PR will need to be raised against the elastic CI stack to allow the parameter to be passed in.