Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DescribeScalingActivities once #95

Merged
merged 1 commit into from
Jul 25, 2023
Merged

DescribeScalingActivities once #95

merged 1 commit into from
Jul 25, 2023

Conversation

DrJosh9000
Copy link
Contributor

And use context.WithTimeout technology instead of separate-goroutine-channel-wait technology.

And move the client and scaler creation outside the loop.

Plus minor cleanups with mustGetEnv{,Int}.

@DrJosh9000 DrJosh9000 requested a review from triarius July 25, 2023 05:10
triarius
triarius approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@triarius triarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making sense of this. LGTM.

@DrJosh9000
DescribeScalingActivities once
f4e46e2 
And use context.WithTimeout technology instead of separate-goroutine-channel-wait technology.
@DrJosh9000 DrJosh9000 merged commit 2251d55 into master Jul 25, 2023
@DrJosh9000 DrJosh9000 deleted the do-it-once branch July 25, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triarius triarius triarius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrJosh9000 @triarius