Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase fails with images on gcr #392

Closed
matthewmcnew opened this issue May 22, 2020 · 3 comments
Closed

Rebase fails with images on gcr #392

matthewmcnew opened this issue May 22, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@matthewmcnew
Copy link
Collaborator

matthewmcnew commented May 22, 2020 •
edited
Loading

An Image configured with gcr creds for a private gcr image is able to build successfully when executing "regular" build but, appears to fail on rebase builds:

[rebase] ERROR: stack not defined on working image

Preliminary research showed that is is not able to access the previous image perhaps by being unable to load gcr credentials.
@matthewmcnew
Copy link
Collaborator Author

It would help debugging if rebase builds provided logging on secret loading similar to: #365.

@matthewmcnew matthewmcnew added the bug Something isn't working label May 22, 2020
@djoyahoy
Copy link
Contributor

djoyahoy commented Jun 1, 2020

This commit 908282b erroneously removed the full path from dockercfg and dockerconfig secfets. I'll have a fix for this out soon.

@mgibson1121
Copy link

Tested and accepted this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matthewmcnew @djoyahoy @mgibson1121