Resolve issue #356 #365
Merged
Resolve issue #356 #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djoyahoy
approved these changes
Apr 27, 2020
matthewmcnew
approved these changes
Apr 28, 2020
|
This looks good! |
|
At the moment, it will only display annotated docker secrets. I believe most users will actually configure |
|
Also, would it be possible to log git secrets? |
|
Those can definitely be future PRs 🙂 |
sukhil-suresh
force-pushed
the
issue_356
branch
from
03efa41 to
6ec105f
Compare
Codecov Report
@@ Coverage Diff @@
## master #365 +/- ##
==========================================
- Coverage 67.62% 67.60% -0.02%
==========================================
Files 80 80
Lines 3296 3294 -2
==========================================
- Hits 2229 2227 -2
Misses 796 796
Partials 271 271
Continue to review full report at Codecov.
|
Improve logging for the prepare step Before ``` $ logs -image tutorial-image -build 1 [prepare] prepare:fetch.go:88: Successfully cloned "https://github.com/spring-projects/spring-petclinic" @ "82cb521d636b282340378d80a6307a08e3d4a4c4" in path "/workspace" ``` After: ``` $ logs -image tutorial-image -build 5 [prepare] Loading secrets for "https://index.docker.io/v1/" from secret "tutorial-registry-credentials" [prepare] Successfully cloned "https://github.com/spring-projects/spring-petclinic" @ "400e3028f48a6c23f5156f6598dd10cb5e6a2849" in path "/workspace" ``` Signed-off-by: Sukhil Suresh <ssuresh@pivotal.io>
- Log loading of dockeconfigjson and dockercfg secrets - Log loading of git secrets - Refactored to avoid passing logger around Sample logging: ``` $ logs -image tutorial-image -build 7 [prepare] Loading secrets for "https://index.docker.io/v1/" from secret "tutorial-registry-credentials" [prepare] Loading secrets for "https://index.docker.io/v1/" from secret "docker-configjson" [prepare] Loading secrets for "registry.pivotal.io" from secret "docker-configjson" [prepare] Loading secrets for "git@github.com" from secret "git-ssh-auth" [prepare] Successfully cloned "https://github.com/sukhil-suresh/spring-petclinic" @ "6108a8a7c2f82ed37968db017e3ff120fb5b2265" in path "/workspace" ``` Signed-off-by: Sukhil Suresh <ssukhil@vmware.com>
sukhil-suresh
force-pushed
the
issue_356
branch
from
6ec105f to
908282b
Compare
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve logging for the prepare step
Before
After:
Signed-off-by: Sukhil Suresh ssuresh@pivotal.io