Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kpack does not handle cache size increase validation correctly when storage class allow expansion is set to false #878

Closed
sambhav opened this issue Oct 31, 2021 · 0 comments
Closed

kpack does not handle cache size increase validation correctly when storage class allow expansion is set to false #878

sambhav opened this issue Oct 31, 2021 · 0 comments
Labels
0.4.2

Comments

@sambhav
Copy link
Contributor

sambhav commented Oct 31, 2021

For some reason, even though it was fixed in #795, kpack does not seem to throw a validation error when cache size is increased.
matthewmcnew added a commit that referenced this issue Nov 4, 2021
@matthewmcnew
Provide HasDefaultStorageClass & IsExpandable on webhook context
c7ef3b1 
- The conversion wehhook will call validation & defaulting which will lead to diverging behavior from the validation and defaulting webhooks
- This prevented v1alpha1 image resources from being defaulted with a volume cache because defaulting was taking place in the conversion webhook without the correct context
Resolves: #878 #873
@matthewmcnew matthewmcnew mentioned this issue Nov 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.4.2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matthewmcnew @sambhav